Aqua.jl icon indicating copy to clipboard operation
Aqua.jl copied to clipboard

Aqua.test_all triggers all deprecation warnings

Open visr opened this issue 3 years ago • 0 comments

Recently GeometryBasics.jl added Aqua.test_all in runtests.jl. It is working well, but the package has quite a few deprecations defined in deprecated.jl.

Since adding Aqua I noticed the full list of deprecation warnings showing up each time the tests are run, here are the last few of them:

WARNING: GeometryBasics.Vec3f0 is deprecated, use Vec3f instead.
  likely near D:\visser_mn\.julia\dev\GeometryBasics\test\runtests.jl:7
WARNING: GeometryBasics.Vec4f0 is deprecated, use Vec4f instead.
  likely near D:\visser_mn\.julia\dev\GeometryBasics\test\runtests.jl:7
WARNING: GeometryBasics.Vecf0 is deprecated, use Vecf instead.
  likely near D:\visser_mn\.julia\dev\GeometryBasics\test\runtests.jl:7
Test Summary:  | Pass  Broken  Total   Time
GeometryBasics |  339       2    341  30.1s
     Testing GeometryBasics tests passed

Uncommenting Aqua.test_all makes these warnings disappear. It's not a serious issue, but it would be nice if these would not show up, since it gives the impression that deprecated bindings are being used during the tests.

visr avatar Aug 03 '22 15:08 visr