SymbolicUtils.jl icon indicating copy to clipboard operation
SymbolicUtils.jl copied to clipboard

Add `@numrule` for rules matching `[-, /, \, \\]` expressions

Open Suavesito-Olimpiada opened this issue 3 years ago • 8 comments

fix #241 adding @numrule as proposed by @shashi

Suavesito-Olimpiada avatar Apr 12 '21 22:04 Suavesito-Olimpiada

Codecov Report

Merging #277 (3693f16) into master (9e85a60) will decrease coverage by 0.60%. The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #277      +/-   ##
==========================================
- Coverage   86.10%   85.49%   -0.61%     
==========================================
  Files          11       12       +1     
  Lines        1137     1193      +56     
==========================================
+ Hits          979     1020      +41     
- Misses        158      173      +15     
Impacted Files Coverage Δ
src/SymbolicUtils.jl 100.00% <ø> (ø)
src/rule.jl 87.85% <93.33%> (+1.61%) :arrow_up:
src/code.jl 79.42% <0.00%> (-4.55%) :arrow_down:
src/methods.jl 82.50% <0.00%> (-3.62%) :arrow_down:
src/api.jl 91.42% <0.00%> (ø)
src/simplify_rules.jl 75.00% <0.00%> (ø)
src/utils.jl 60.37% <0.00%> (+0.37%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9e85a60...3693f16. Read the comment docs.

codecov-io avatar Apr 12 '21 22:04 codecov-io

This is pretty awesome!! Thank you!

shashi avatar Apr 15 '21 01:04 shashi

Can we try doing these in simplify_rules.jl?

shashi avatar Apr 15 '21 01:04 shashi

Yeah! of course, I just wanted to have some insight on the aproach and the implementation, so if it was OK then I could worked it further.

If you think this is fine, I'll get my hand into symplify_rules.jl. :smile:

Suavesito-Olimpiada avatar Apr 15 '21 01:04 Suavesito-Olimpiada

So I have been in finals and I hadn't have time to finish this. But once this month ends I'll be able to work in this and another issues. Just wanted to say that I haven't abandoned this PR.

Suavesito-Olimpiada avatar May 11 '21 23:05 Suavesito-Olimpiada

Codecov Report

Merging #277 (546f324) into master (16066fa) will increase coverage by 0.12%. The diff coverage is 80.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #277      +/-   ##
==========================================
+ Coverage   83.32%   83.44%   +0.12%     
==========================================
  Files          12       12              
  Lines        1319     1365      +46     
==========================================
+ Hits         1099     1139      +40     
- Misses        220      226       +6     
Impacted Files Coverage Δ
src/SymbolicUtils.jl 100.00% <ø> (ø)
src/rule.jl 87.27% <80.64%> (-8.89%) :arrow_down:
src/ordering.jl 88.37% <0.00%> (-1.17%) :arrow_down:
src/adjoints.jl 100.00% <0.00%> (ø)
src/polyform.jl 93.88% <0.00%> (+0.16%) :arrow_up:
src/types.jl 83.84% <0.00%> (+0.23%) :arrow_up:
src/methods.jl 81.81% <0.00%> (+0.42%) :arrow_up:
src/simplify_rules.jl 91.66% <0.00%> (+9.84%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 16066fa...546f324. Read the comment docs.

codecov-commenter avatar Dec 03 '21 05:12 codecov-commenter

Coming back to check this. Now it seems even messier than last time, any commentaries?

Suavesito-Olimpiada avatar Dec 03 '21 09:12 Suavesito-Olimpiada

Yeah since then Div has been introduced. It should actually help in this case. We still badly need this feature!

shashi avatar Dec 04 '21 17:12 shashi