Metatheory.jl
Metatheory.jl copied to clipboard
fixed issues discovered bj JET.jl
Hi,
after patching JET.jl with this not yet merged PR, it's now possible to run report_package(Metatheory)
with Julia 1.8.
The current PR fixes most real issues reported by JET. Namely:
- It removes old functions which are never called, some of which are broken
- It fixes references to undefined variables
- It adds
something(x)
after checkingx !== nothing
to get more optimized code.
Codecov Report
Merging #138 (c2afdce) into master (305a9d2) will increase coverage by
0.20%
. The diff coverage is57.14%
.
@@ Coverage Diff @@
## master #138 +/- ##
==========================================
+ Coverage 76.64% 76.84% +0.20%
==========================================
Files 15 15
Lines 1400 1382 -18
==========================================
- Hits 1073 1062 -11
+ Misses 327 320 -7
Impacted Files | Coverage Δ | |
---|---|---|
src/EGraphs/analysis.jl | 85.18% <0.00%> (+1.03%) |
:arrow_up: |
src/EGraphs/saturation.jl | 93.33% <0.00%> (-0.08%) |
:arrow_down: |
src/Rewriters.jl | 32.32% <0.00%> (ø) |
|
src/utils.jl | 37.93% <ø> (+1.08%) |
:arrow_up: |
src/EGraphs/egraph.jl | 89.68% <100.00%> (-0.17%) |
:arrow_down: |
src/EGraphs/ematch.jl | 92.00% <100.00%> (-0.07%) |
:arrow_down: |
src/EGraphs/Schedulers.jl | 39.18% <0.00%> (-0.82%) |
:arrow_down: |
src/Patterns.jl | 72.34% <0.00%> (-0.58%) |
:arrow_down: |
... and 3 more |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
I guess the failures are not related to this MR, but I still have to check manually, I'll merge after checking. Thanks a lot
fyi, latest 0.6.2 release can now analyse Metatheory.jl