TimeSeries.jl Adds retime

Closes #439

Dec 14 '24 21:12 ValentinKaisermayer

It works off of #528

Dec 14 '24 21:12 ValentinKaisermayer

@iblislin What do you think about the interface? I have chosen singleton types instead of Symbols so that a dispatch system can be implemented.

Dec 14 '24 21:12 ValentinKaisermayer

What do you think about the interface? I have chosen singleton types instead of Symbols so that a dispatch system can be implemented.

well, I personally prefer the Symbol, and build with literal type dispatching.

e.g.

julia> f(::Val{:abc}) = 42
f (generic function with 1 method)

julia> f(x::Symbol) = f(Val(x))
f (generic function with 2 methods)

julia> f(:abc)
42

but I'm not sure about the performance penalty. Maybe you could give that a try.

Dec 16 '24 05:12 iblislin

@iblislin I added a documentation page as well.

Jan 19 '25 20:01 ValentinKaisermayer

Could you sync (rebase or just merge) this branch with master?

Jan 20 '25 00:01 iblislin

Could you sync (rebase or just merge) this branch with master?

Done

Jan 20 '25 20:01 ValentinKaisermayer

@iblislin any thoughts?

Jan 21 '25 20:01 ValentinKaisermayer

Any idea about the Documenter build failures?

Tons of segfault :thinking: https://github.com/JuliaStats/TimeSeries.jl/actions/runs/12873732102/job/35891842966?pr=529#step:7:1

Jan 22 '25 00:01 iblislin

Any idea about the Documenter build failures?

Tons of segfault 🤔 https://github.com/JuliaStats/TimeSeries.jl/actions/runs/12873732102/job/35891842966?pr=529#step:7:1

Not really.

Jan 22 '25 19:01 ValentinKaisermayer

Could you check that is @inbounds fit for this PR or not?

Jan 24 '25 06:01 iblislin

@iblislin can you review again?

Mar 09 '25 19:03 ValentinKaisermayer

Could you merge from master, and check that if the CI passed or not?

I just sent #534 .

Mar 20 '25 05:03 iblislin

Could you merge from master, and check that if the CI passed or not?

I just sent #534 .

LGTM

Apr 03 '25 17:04 ValentinKaisermayer

@iblislin any plans on releasing a new minor version?

Aug 29 '25 11:08 ValentinKaisermayer

ah, there are still a CI failure on master. I will fix it this Saturday.... sorry for the delay

Sep 03 '25 23:09 iblislin

Or.. we could just release a new version, the failure is just about linter's groans.

Sep 04 '25 00:09 iblislin