JuliaStats
Remove code for unsupported Julia versions
When looking through tdist.jl, I noticed that there is some code left for nowadays unsupported Julia versions.
Edit: Somehow read 0.7 instead of 1.7, so clearly one of the branches is still needed...
Edit2: Maybe it would actually be better to use log2mexp here to continue performing operations in log-space.
Hmm, I think log2mexp would be a better approach - but it seems it requires adding a _expm1(::Float64) definition to LogExpFunctions? Or to use a _log2mexp function on older Julia versions.
Codecov Report
Base: 61.58% // Head: 58.37% // Decreases project coverage by -3.21% :warning:
Coverage data is based on head (
1304710) compared to base (7217d12). Patch coverage: 100.00% of modified lines in pull request are covered.
Additional details and impacted files
@@ Coverage Diff @@
## master #155 +/- ##
==========================================
- Coverage 61.58% 58.37% -3.21%
==========================================
Files 14 14
Lines 617 543 -74
==========================================
- Hits 380 317 -63
+ Misses 237 226 -11
| Impacted Files | Coverage Δ | |
|---|---|---|
| src/distrs/tdist.jl | 100.00% <100.00%> (+2.27%) |
:arrow_up: |
| src/inverse.jl | 25.00% <0.00%> (-75.00%) |
:arrow_down: |
| src/distrs/binom.jl | 75.00% <0.00%> (-3.58%) |
:arrow_down: |
| src/misc.jl | 85.71% <0.00%> (-3.18%) |
:arrow_down: |
| src/tvpack.jl | 14.51% <0.00%> (-1.97%) |
:arrow_down: |
| src/distrs/gamma.jl | 97.43% <0.00%> (-0.49%) |
:arrow_down: |
| src/distrs/norm.jl | 97.05% <0.00%> (-0.38%) |
:arrow_down: |
| src/rmath.jl | 100.00% <0.00%> (ø) |
|
| src/distrs/beta.jl | 100.00% <0.00%> (ø) |
|
| ... and 2 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
The remaining test errors are caused by the recent Rmath update, see https://github.com/JuliaStats/StatsFuns.jl/pull/156