StatsBase.jl icon indicating copy to clipboard operation
StatsBase.jl copied to clipboard

Published 20 hours ago • verified publisher icon JuliaStats

Fix some issues with sampling

Open ararslan opened this issue 2 years ago • 2 comments

This PR is separated into three distinct changes:

  1. Fixing #871 and #877
  2. NFC to use testsets in weighted sampling tests
  3. Fix weighted sampling with UnitWeights

See commit messages for additional info as applicable.

Fixes #871 Fixes #877

ararslan avatar Jul 05 '23 20:07 ararslan

What's holding up this PR?

ParadaCarleton avatar Aug 22 '23 19:08 ParadaCarleton

What's holding up this PR?

The following, which I've not had time for:

  • [ ] Remember this PR exists
  • [ ] Determine whether executing the checks twice introduces noticeable overhead
  • [ ] If it does, don't run them twice
  • [ ] Remove some internal functions from the documentation

ararslan avatar Aug 24 '23 00:08 ararslan