StatsAPI.jl
StatsAPI.jl copied to clipboard
Add `ConvergenceException` from StatsBase
I've added the folks who contributed the type and improvements to it and its documentation as coauthors of the commit. (Apologies if I missed anyone.) I've made only very minor adjustments from its definition in StatsBase.
Codecov Report
Merging #20 (6a1063d) into main (14e0ba7) will not change coverage. The diff coverage is
100.00%.
@@ Coverage Diff @@
## main #20 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 36 49 +13
=========================================
+ Hits 36 49 +13
| Impacted Files | Coverage Ξ | |
|---|---|---|
| src/statisticalmodel.jl | 100.00% <100.00%> (ΓΈ) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Bump @nalimilan, any thoughts on this?
Sorry for the delay. Looks good, I just wonder where we should draw the line regarding what to add to StatsAPI. While this is supposed to be mainly an interface package, we already added a few methods for statistical models, and this PR adds a few more. Probably OK, but we should stop at some point. :-)
Can you also bump the version?
Sorry for the delay
No worries π
I just wonder where we should draw the line regarding what to add to StatsAPI
Perhaps worth determining what the precise scope of the package is before adding more random stuff to it. π I guess this addition is a bit of an outlier amidst the rest of the functionality in that everything else is either a stub definition or a sensible fallback definition atop which more specific methods can be defined. This, on the other hand, is a piece of completely self-contained functionality that won't be extended, only used. So perhaps it makes sense to just keep it in StatsBase.