LogExpFunctions.jl icon indicating copy to clipboard operation
LogExpFunctions.jl copied to clipboard
verified publisher icon JuliaStats

add `logabstanh`

Open oscardssmith opened this issue 1 year ago • 2 comments

as requested by @c05 on slack. This has 15 ULP for Float64, and 5 ULP for Float32.

oscardssmith avatar Nov 16 '24 07:11 oscardssmith

Something missing here? Or can this be merged ?

3f6a avatar Nov 25 '24 22:11 3f6a

Can you add tests and update the docs? Probably should also add a ChainRules definition.

devmotion avatar Nov 25 '24 22:11 devmotion

Should I re-open and rebase to add Float32 and Float64 fast-paths?

oscardssmith avatar Aug 18 '25 14:08 oscardssmith

It might be simpler to just revert 39127b6b4ef9fa4cb38b0f5d4136ebba64fb41fd instead of rebasing. For a start I mean.

nsajko avatar Aug 18 '25 15:08 nsajko

@oscardssmith: choose whatever is most convenient for you, but having these methods would be very welcome. The new testing framework should be sufficient for tests.

tpapp avatar Aug 18 '25 15:08 tpapp

can you reopen? I seem to not have permission to.

oscardssmith avatar Aug 18 '25 15:08 oscardssmith

Unfortunately I am unable, Github says "that these commits are already merged."

tpapp avatar Aug 18 '25 15:08 tpapp

Yeah, all of them are part of the merged PR.

nsajko avatar Aug 18 '25 15:08 nsajko

ah. Will re-create then.

oscardssmith avatar Aug 18 '25 15:08 oscardssmith