Distributions.jl
Distributions.jl copied to clipboard
Fix `fit` docs
fit
doesn't need a specific docstring just for Beta
.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 85.96%. Comparing base (
818814f
) to head (08ad0fb
).
Additional details and impacted files
@@ Coverage Diff @@
## master #1746 +/- ##
=======================================
Coverage 85.96% 85.96%
=======================================
Files 144 144
Lines 8647 8647
=======================================
Hits 7433 7433
Misses 1214 1214
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Any objections to merging this?
I mentioned this in Issue #1701. For sure docstring for Beta should be removed, but currently fit has no general docstring for a distribution fit. The question is should it be added.
IMO we should add a docstring for generic fit
, if this can be done in a clear and informative way, before removing the docstring for Beta
. The possible problem with a generic docstring is that it is not clear which distributions are supported and what the (keyword) arguments are for the individual distributions.
maybe related #1748
I assume now that Poisson
is not supported as stated in doc of fit_mle
.
Anything else to do before merging?
Anything else or can I merge?
Anything else?
@devmotion should I merge?
Merge?
Why was this merged? Docs seem to be broken (missing docstrings): https://juliastats.org/Distributions.jl/dev/fit/