Distributions.jl
Distributions.jl copied to clipboard
Use besselix instead of besseli for better numerical stability.
This PR improves numerical stability for the von-Mises-Fisher distribution for large values of κ
.
Will do!
Codecov Report
Base: 85.94% // Head: 85.94% // No change to project coverage :thumbsup:
Coverage data is based on head (
6f8536e
) compared to base (5566488
). Patch coverage: 100.00% of modified lines in pull request are covered.
Additional details and impacted files
@@ Coverage Diff @@
## master #1598 +/- ##
=======================================
Coverage 85.94% 85.94%
=======================================
Files 129 129
Lines 8083 8083
=======================================
Hits 6947 6947
Misses 1136 1136
Impacted Files | Coverage Δ | |
---|---|---|
src/multivariate/vonmisesfisher.jl | 93.33% <100.00%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Okay, I hope tests are okay now?
I think the one failing test is unrelated to my changes?
Thank you for the PR!
I wanted to add these improvements, so I applied the suggestions and hope this is fine with you.