Distributions.jl icon indicating copy to clipboard operation
Distributions.jl copied to clipboard
verified publisher icon JuliaStats

Doc mentions MAP but package doesn't allow it

Open gdalle opened this issue 3 years ago • 6 comments

This page of the doc mentions Maximum-A-Posteriori Estimation, but I think it may be outdated since Distributions.jl doesn't seem to allow it. Maybe it could be removed?

gdalle avatar May 30 '22 13:05 gdalle

AFAICT fit_map was moved to https://github.com/JuliaStats/ConjugatePriors.jl (which would also explain the broken link).

devmotion avatar May 30 '22 13:05 devmotion

Yeah, and that package isn't in very good shape at the moment, so maybe just deleting the section from the Distributions.jl documentation would be best?

gdalle avatar May 30 '22 13:05 gdalle

Hmm yes it seems it has to be updated a bit (which seems totally possible though, I left some comments in @mschauer's PR). I think ideally we would point to ConjugatePriors in that section but maybe currently users should be warned that it was neglected a bit and needs more love.

devmotion avatar May 30 '22 20:05 devmotion

Yeah I'm trying to clean up that PR too but I'm not sure I will have time before this summer

gdalle avatar May 30 '22 21:05 gdalle

For future reference, here is the PR in question: https://github.com/JuliaStats/ConjugatePriors.jl/pull/43

gdalle avatar May 30 '22 21:05 gdalle