DimensionalityReduction.jl icon indicating copy to clipboard operation
DimensionalityReduction.jl copied to clipboard

REQUIRE DataFrames?

Open glennsweeney opened this issue 11 years ago • 7 comments

Why does this package require DataFrames? I cannot find any reference (except in a comment) to the package; though I am no DataFrames expert.

More of a curiosity than anything; I was surprised to see it installed alongside this tool.

glennsweeney avatar Apr 30 '14 07:04 glennsweeney

That requirement is probably just an anachronism and should get taken out. I'm going to make some changes to the package today, so I'll deal with that at the same time.

johnmyleswhite avatar Apr 30 '14 19:04 johnmyleswhite

Sounds great. In a related note, I noticed that ICA is deprecated. Is there a reason for this, and/or a recommended replacement? If not, I will start implementing a version this weekend for my own work and would be happy to give you a pull request when it is completed.

glennsweeney avatar Apr 30 '14 21:04 glennsweeney

The ICA implementation seems pretty unreliable. Arguably it should be removed, but it's just deprecated for now in case somebody wants to work on it.

johnmyleswhite avatar Apr 30 '14 22:04 johnmyleswhite

I need it for some work, so if I have time I'll see what I can do to clean it up or write a fresh implementation.

On 04/30/2014 06:13 PM, John Myles White wrote:

The ICA implementation seems pretty unreliable. Arguably it should be removed, but it's just deprecated for now in case somebody wants to work on it.

— Reply to this email directly or view it on GitHub https://github.com/JuliaStats/DimensionalityReduction.jl/issues/18#issuecomment-41857993.

glennsweeney avatar Apr 30 '14 22:04 glennsweeney

That would be great. We really need somebody who knows ICA well to work on it.

johnmyleswhite avatar Apr 30 '14 22:04 johnmyleswhite

Haven't forgotten this. I underestimated how long a reliable implementation would take from scratch; hopefully when school calms down I can get back on it.

glennsweeney avatar May 31 '14 19:05 glennsweeney

No rush at all.

johnmyleswhite avatar May 31 '14 19:05 johnmyleswhite