JuliaStats
Issue #64: added n_init to kmeans
Sorry, I am still figuring out the pull request process and think I accidentally closed last one. Here is new request with suggested cleanups.
Apologies.
EDIT: fixes #64, original PR #77
If you accidentally close a pull request, you can just click "reopen," no need to open a new one.
Sorry, I realize the whitespace pedantry is probably annoying. Once my outstanding style comments are addressed I think this will be good to go. Thanks for the contribution!
No I completely apologize for these small things that I didn't take care to consider. Thanks for helping me learn about this process. It is preparing me for future commits.
This looks great to me, though I'd like a second pair of eyes on the implementation before it's merged. @KristofferC?
This is rather old, but Clustering.jl hasn't had any active maintainers in a while. I just fixed the merge conflicts. This seems like a nice addition, but the documentation needs to be updated to reflect the interface change. @lbollar, are you still available to update this?
I'll try and get some time soon and update.
On Aug 26, 2017 9:38 AM, "Kevin Squire" [email protected] wrote:
This is rather old, but Clustering.jl hasn't had any active maintainers in a while. I just fixed the merge conflicts. This seems like a nice addition, but the documentation needs to be updated to reflect the interface change. @lbollar https://github.com/lbollar, are you still available to update this?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/JuliaStats/Clustering.jl/pull/78#issuecomment-325133695, or mute the thread https://github.com/notifications/unsubscribe-auth/AGB4lm6DB9wlG8B7KfKt1mU035r55gbxks5scC3jgaJpZM4KLdq3 .
I think it's worth merging. I'd rename the parameter to ntries. The default (10) seems reasonable given that the method is quite fast.
Obviously, the PR has to be updated to 1.0 (@compat), and the param docs added to kmeans.rst.
