SparseArrays.jl icon indicating copy to clipboard operation
SparseArrays.jl copied to clipboard

Fix "no method matching" test

Open apaz-cli opened this issue 2 years ago • 1 comments

Right now we're thinking about changing the MethodError message. Unfortunately, this breaks a lot of tests, including this one. Discussion at https://github.com/JuliaLang/julia/pull/47369.

~~If the change below does happen, merge this PR afterwards. https://github.com/JuliaLang/julia/pull/47369/commits/44367ce8fed017c1aee6a01fb273b12653e7f5c9~~

apaz-cli avatar Nov 17 '22 16:11 apaz-cli

Codecov Report

Merging #288 (8703152) into main (311b4b4) will increase coverage by 0.01%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #288      +/-   ##
==========================================
+ Coverage   93.76%   93.78%   +0.01%     
==========================================
  Files          12       12              
  Lines        7334     7335       +1     
==========================================
+ Hits         6877     6879       +2     
+ Misses        457      456       -1     
Impacted Files Coverage Δ
src/sparsevector.jl 95.01% <0.00%> (+<0.01%) :arrow_up:
src/SparseArrays.jl 82.35% <0.00%> (+5.88%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Nov 22 '22 18:11 codecov-commenter

@vtjnash is this good to merge?

ViralBShah avatar Feb 08 '23 17:02 ViralBShah