LinearOperators.jl icon indicating copy to clipboard operation
LinearOperators.jl copied to clipboard

Add JLArrays, Metal and AMDGPU extensions and S kwarg tests (rebased)

Open dpo opened this issue 1 year ago • 4 comments

dpo avatar Oct 16 '24 22:10 dpo

@nHackel It looks like there's a dependency issue with Julia 1.6 (that should perhaps be abandoned at this point), and a test error with Julia 1: https://github.com/JuliaSmoothOptimizers/LinearOperators.jl/actions/runs/11375178950/job/31645355758?pr=351#step:6:495

dpo avatar Oct 16 '24 23:10 dpo

Package name latest stable
AdaptiveRegularization
CaNNOLeS
FletcherPenaltySolver
JSOSolvers
JSOSuite
LLSModels
NLPModels
NLPModelsModifiers
PROPACK
PartiallySeparableNLPModels
PartiallySeparableSolvers
PartitionedStructures
PartitionedVectors
Percival
QuadraticModels
RipQP
SolverTools

github-actions[bot] avatar Oct 16 '24 23:10 github-actions[bot]

Package name latest stable
AdaptiveRegularization
CaNNOLeS
FletcherPenaltySolver
JSOSolvers
JSOSuite
LLSModels
NLPModels
NLPModelsModifiers
PROPACK
PartiallySeparableNLPModels
PartiallySeparableSolvers
PartitionedStructures
PartitionedVectors
Percival
QuadraticModels
RipQP
SolverTools

github-actions[bot] avatar Oct 16 '24 23:10 github-actions[bot]

I'll try to fix the test issue over the weekend.

W can probably bump the compat to 1.10 since that is the new LTS

nHackel avatar Oct 17 '24 04:10 nHackel

@dpo if we want to update from LTS 1.6 to the current LTS 1.10, should we do that in a seperate PR?

I've also looked into the test failure and for me it only happens in a 1.11 version and it seems like the SymTriDiagonal array and its LinearOperator don't work for GPU arrays anyways. At least they didnt work for JLArrays and CuArrays when I tested it

nHackel avatar Nov 01 '24 09:11 nHackel

@nHackel I just opened #355 to change from 1.6 to 1.10.

Maybe just comment out the SymTridiagonal unit tests?!

dpo avatar Nov 22 '24 16:11 dpo

@dpo I don't have permission to edit this branch, but maybe I oversaw something.

I've fetched this branch to my fork and made a new PR to this branch with the test commented out. If there is a way that is more straightforward or convenient for you, let me know and I update it

nHackel avatar Nov 22 '24 21:11 nHackel

Package name latest stable
AdaptiveRegularization
CaNNOLeS
FletcherPenaltySolver
JSOSolvers
JSOSuite
LLSModels
NLPModels
NLPModelsModifiers
PROPACK
PartiallySeparableNLPModels
PartiallySeparableSolvers
PartitionedStructures
PartitionedVectors
Percival
QuadraticModels
RipQP
SolverTools

github-actions[bot] avatar Nov 23 '24 23:11 github-actions[bot]

Many thanks @nHackel !

dpo avatar Nov 23 '24 23:11 dpo