CUTEst.jl icon indicating copy to clipboard operation
CUTEst.jl copied to clipboard

draft single precision support

Open dpo opened this issue 5 years ago • 10 comments

These are preliminary changes to support calling CUTEst in single precision. I haven't yet added single-precision tests. I see test failures locally that are probably due to an updated SIF collection (see #176).

The changes look a bit messy because I took the docstrings out of the @eval blocks.

dpo avatar Mar 02 '19 22:03 dpo

Coverage Status

Coverage decreased (-0.6%) to 81.772% when pulling a42fc5c9efa5c3d49a3e6a12c76ecb97d6101635 on single-precision into 04daee43e95c04a155c3926b87a07954c6ebb2ce on master.

coveralls avatar Mar 02 '19 22:03 coveralls

@abelsiqueira Does your CUTEst installer also install the single precision library? If not, we're going to need it.

dpo avatar Mar 02 '19 23:03 dpo

Updating here: https://github.com/abelsiqueira/linux-cutest/pull/15

abelsiqueira avatar Mar 03 '19 14:03 abelsiqueira

Codecov Report

Merging #177 into master will decrease coverage by 0.81%. The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #177      +/-   ##
==========================================
- Coverage   82.38%   81.56%   -0.82%     
==========================================
  Files           5        6       +1     
  Lines         386      396      +10     
==========================================
+ Hits          318      323       +5     
- Misses         68       73       +5
Impacted Files Coverage Δ
src/CUTEst.jl 79.84% <66.66%> (-2.36%) :arrow_down:
src/core_interface.jl 69.23% <69.23%> (-3.63%) :arrow_down:
src/precision_dependent.jl 75% <75%> (ø)
src/julia_interface.jl 95.45% <94.48%> (-0.03%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 04daee4...ddfc50c. Read the comment docs.

codecov[bot] avatar Mar 03 '19 15:03 codecov[bot]

Codecov Report

Merging #177 into master will decrease coverage by 0.56%. The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #177      +/-   ##
==========================================
- Coverage   82.38%   81.81%   -0.57%     
==========================================
  Files           5        6       +1     
  Lines         386      396      +10     
==========================================
+ Hits          318      324       +6     
- Misses         68       72       +4
Impacted Files Coverage Δ
src/CUTEst.jl 80.62% <66.66%> (-1.59%) :arrow_down:
src/core_interface.jl 69.23% <69.23%> (-3.63%) :arrow_down:
src/precision_dependent.jl 75% <75%> (ø)
src/julia_interface.jl 95.45% <94.48%> (-0.03%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 04daee4...a42fc5c. Read the comment docs.

codecov[bot] avatar Mar 03 '19 15:03 codecov[bot]

https://raw.githubusercontent.com/abelsiqueira/linux-cutest/v0.4.2/install.sh still says VERSION=0.4.1. Not sure if it matters. I'll update the version number in build.jl and see if it works.

dpo avatar Mar 03 '19 16:03 dpo

It's looking good! The Linux tests pass. Now I'll have to add single-precision tests.

dpo avatar Mar 03 '19 16:03 dpo

Looking very good, thanks.

abelsiqueira avatar Mar 03 '19 17:03 abelsiqueira

This is what's being tested in NLPModels.jl, perhaps it can be reused.

abelsiqueira avatar Mar 03 '19 17:03 abelsiqueira

Yes, those are definitely important tests.

dpo avatar Mar 03 '19 17:03 dpo

Done in #366

amontoison avatar Aug 21 '24 03:08 amontoison