SeisNoise.jl icon indicating copy to clipboard operation
SeisNoise.jl copied to clipboard

SeisNoise v0.5.3 fails to compile on M1 Mac

Open haakon-e opened this issue 2 years ago • 2 comments

due to pinned dependencies in SeisIO. See https://github.com/jpjones76/SeisIO.jl/issues/93 and proposed fix https://github.com/jpjones76/SeisIO.jl/pull/94. Depending on how the SeisIO version is bumped after that fix, compat changes may be needed here too.

In a local instance of SeisNoise.jl that depends on SeisIO.jl with the proposed fix implemented, compilation of this package is successful.

haakon-e avatar Oct 24 '22 21:10 haakon-e

Great, thanks for letting me know! I have not tested SeisNoise on an M1/M2. I'll get in touch with Josh Jones to see if he can merge quickly - should be an easy fix.

tclements avatar Oct 25 '22 00:10 tclements

I think the comment using my forked version of SeisIO I mentioned in #101 should fix for now. We are working on moving to use SeisBase.jl in the future.

tclements avatar Nov 11 '22 20:11 tclements

We moved to using SeisBase.jl, can confirm SeisNoise.jl works on macOS.

tclements avatar Dec 10 '23 18:12 tclements