VectorizationBase.jl icon indicating copy to clipboard operation
VectorizationBase.jl copied to clipboard

Migrate to opaque pointers

Open miguelraz opened this issue 9 months ago • 2 comments

This PR

  • Temporarily disables Aqua and some tests to speed up test feedback. These will be turn on again after the corresponding tests pass
  • deletes JULIAPOINTER = "i32"/"i64" and instead uses ptr everywhere

Once the current set of tests pass I'll work on the remaining Special Functions and friends test sets but wanted to get some progress here first.

miguelraz avatar May 12 '24 07:05 miguelraz

Currently getting a segfault and the trace here is very overwhelming - I've looked at each of these addresses but they don't lead me to places where I've changed the code around.

(running Pkg.test())
masks.jl

[25965] signal 11 (1): Segmentation fault
in expression starting at /home/miguelraz/oss/LOOPS/VectorizationBase.jl/test/runtests.jl:8
macro expansion at /home/miguelraz/oss/LOOPS/VectorizationBase.jl/src/llvm_intrin/memory_addr.jl:1417 [inlined]
__vstore! at /home/miguelraz/oss/LOOPS/VectorizationBase.jl/src/llvm_intrin/memory_addr.jl:1417 [inlined]
macro expansion at /home/miguelraz/oss/LOOPS/VectorizationBase.jl/src/vecunroll/memory.jl:2886 [inlined]
__vstore! at /home/miguelraz/oss/LOOPS/VectorizationBase.jl/src/vecunroll/memory.jl:2886 [inlined]
_vstore! at /home/miguelraz/oss/LOOPS/VectorizationBase.jl/src/strided_pointers/stridedpointers.jl:199 [inlined]
vstore! at /home/miguelraz/oss/LOOPS/VectorizationBase.jl/src/llvm_intrin/memory_addr.jl:2094
unknown function (ip: 0x74c1ec58efdd)
macro expansion at /home/miguelraz/oss/LOOPS/VectorizationBase.jl/test/runtests.jl:412 [inlined]
macro expansion at /cache/build/tester-amdci4-13/julialang/julia-master/usr/share/julia/stdlib/v1.12/Test/src/Test.jl:1700 [inlined]
macro expansion at /home/miguelraz/oss/LOOPS/VectorizationBase.jl/test/runtests.jl:227 [inlined]
macro expansion at ./timing.jl:578 [inlined]
macro expansion at /home/miguelraz/oss/LOOPS/VectorizationBase.jl/test/runtests.jl:224 [inlined]
macro expansion at /cache/build/tester-amdci4-13/julialang/julia-master/usr/share/julia/stdlib/v1.12/Test/src/Test.jl:1700 [inlined]
macro expansion at /home/miguelraz/oss/LOOPS/VectorizationBase.jl/test/runtests.jl:11 [inlined]
macro expansion at ./timing.jl:578 [inlined]
top-level scope at /home/miguelraz/oss/LOOPS/VectorizationBase.jl/test/runtests.jl:312
jl_toplevel_eval_flex at /cache/build/tester-amdci4-13/julialang/julia-master/src/toplevel.c:960
jl_toplevel_eval_flex at /cache/build/tester-amdci4-13/julialang/julia-master/src/toplevel.c:909
ijl_toplevel_eval at /cache/build/tester-amdci4-13/julialang/julia-master/src/toplevel.c:980
ijl_toplevel_eval_in at /cache/build/tester-amdci4-13/julialang/julia-master/src/toplevel.c:1022
eval at ./boot.jl:432 [inlined]

miguelraz avatar May 12 '24 13:05 miguelraz

Currently getting a segfault and the trace here is very overwhelming - I've looked at each of these addresses but they don't lead me to places where I've changed the code around.

Yeah, segfaults are going to happen when loading and storing to totally invalid pointers.

chriselrod avatar May 12 '24 14:05 chriselrod