Polyester.jl icon indicating copy to clipboard operation
Polyester.jl copied to clipboard

No exception/error raised for negative logarithm

Open DanielDoehring opened this issue 2 years ago • 3 comments

It is a bit tough for me to provide a MWE showcasing this behaviour, but you can reproduce this using my branch forked from Trixi.jl.

Then, execute the example https://github.com/DanielDoehring/Trixi.jl/blob/MultiThreadedNegativeLog/examples/tree_2d_dgsem/elixir_mhd_rotor_reproducibility.jl

with one and 16 threads. You should observe that the version with 1 thread crashes as expected, but for the multi-threaded version no error is raised (in contrast to the built-in Julia threads). See also the discussion in the corresponding issue in the Trixi.jl repository.

DanielDoehring avatar Dec 08 '23 09:12 DanielDoehring

Presumably caused by: https://github.com/JuliaSIMD/ThreadingUtilities.jl/commit/290f4a2478f7ad06d869876c4949b0ae356a76f2 I wanted cleaner JET reports.

chriselrod avatar Dec 10 '23 21:12 chriselrod

Ok, I will check if this behaviour still occurs with v0.5.1 of ThreadingUtilities.

DanielDoehring avatar Dec 10 '23 22:12 DanielDoehring

By switching to v0.5.1 I receive the report that the task failed (which is sufficient for me) but the program still (somehow) continues.

DanielDoehring avatar Dec 11 '23 08:12 DanielDoehring