TagBot icon indicating copy to clipboard operation
TagBot copied to clipboard

Published 20 hours ago • verified publisher icon JuliaRegistries

Look up release branch in commit comment

Open christopher-dG opened this issue 3 years ago • 0 comments

https://github.com/JuliaRegistries/TagBot/blob/bb54f2ea972cea2273ddfa926548c72ac2bb4bda/tagbot/action/repo.py#L151-L154

The code above means "Static release branch set in TagBot config if it's set, otherwise the repo's default branch". It's ignoring release branch info from a Registrator invocation like @JuliaRegistrator register branch=foo.

The actual effect of this is we miss out on the nice "N commits since this release" for those latter releases.

The priority for release branch selection should be:

  1. Branch specified by Registrator invocation
  2. Release branch specified in TagBot config
  3. Default branch

Right now we're just missing (1). We can look up the commit comment by reading the registry PR body, but we're out of luck for the web UI.

I won't get to this soon but I'll keep it in mind for the rewrite :tm:

christopher-dG avatar Apr 16 '21 19:04 christopher-dG