Registrator.jl icon indicating copy to clipboard operation
Registrator.jl copied to clipboard

Confusing instructions from JuliaRegistrator

Open cscherrer opened this issue 4 years ago • 7 comments

Hi, I found this warning message really confusing:

Also, note the warning: Version 0.1.3 skips over 0.1.2 This can be safely ignored. However, if you want to fix this you can do so. Call register() again after making the fix. This will update the Pull request.

There's some discussion on it here: https://discourse.julialang.org/t/confusing-instructions-from-juliaregistrator/53833

Thanks @ericphanson :)

cscherrer avatar Jan 23 '21 15:01 cscherrer

I think this is for Registrator.jl, right?

DilumAluthge avatar Jan 23 '21 18:01 DilumAluthge

No, I think it’s a RegistryCI issue, since the confusing wording is in the automerge message

ericphanson avatar Jan 23 '21 18:01 ericphanson

I believe the wording in question is in the Registrator comment, right?

@cscherrer Is this what you're referring to? https://github.com/cscherrer/NestedTuples.jl/commit/cf2fcc29436b5e5411e8db3c6b5aa858555b18b4#commitcomment-46276353

DilumAluthge avatar Jan 23 '21 18:01 DilumAluthge

@DilumAluthge yep that's it

cscherrer avatar Jan 23 '21 19:01 cscherrer

Now that we have AutoMerge, maybe we should just remove this message from Registrator.

DilumAluthge avatar Jan 23 '21 19:01 DilumAluthge

Whoops, I mixed it up with the automerge comment. Agreed that it’s better for these to be just in one place, ie in the automerge message(except for errors where it’s actually not going to open the PR or something like that).

ericphanson avatar Jan 23 '21 19:01 ericphanson

Whoops, I mixed it up with the automerge comment. Agreed that it’s better for these to be just in one place, ie in the automerge message(except for errors where it’s actually not going to open the PR or something like that).

I agree. All warnings and non-fatal errors should go in the AutoMerge comment.

DilumAluthge avatar Jan 23 '21 20:01 DilumAluthge