Registrator.jl icon indicating copy to clipboard operation
Registrator.jl copied to clipboard

Allow person triggering registration to close it

Open tlienart opened this issue 4 years ago • 7 comments

Given I'm responsible for my fair share of errors on that front, I was wondering whether it'd be possible for someone triggering a @JuliaRegistrator register to also close the relevant PR.

Use case (which happened to me half a dozen time with @DilumAluthge always kindly mopping up afterwards):

  • I trigger an update, there's some error in it (e.g. wrong version number or I forgot some compat bounds 😠 )
  • I don't check the messages, and keep working on something else, increment the version counter and tag another update
  • result: several open PRs in the registry which are all wrong.

By the time I realise the last point, I'm like... shit... let's only fix the first one and write an apologetic note in the others. But I'd feel better if I could just close PRs myself.

Would it be possible for the person who triggers the update to have the permission to close the resulting PR or there's no permission mode that would allow just that? Or maybe add something to the @JuliaRegistrator so that I could write @JuliaRegistrator cancel and it would close all open PRs and I'd have to start again (which might be a good compromise)

Thanks!

tlienart avatar May 24 '20 10:05 tlienart

Certainly a good idea. I'm not sure how to implement it.

DilumAluthge avatar May 25 '20 21:05 DilumAluthge

I'm under the impression that the route @JuliaRegistrator cancel might be easier to pull off. @christopher-dG would you know?

tlienart avatar May 26 '20 06:05 tlienart

@nkottary is the best one to ask about that code!

christopher-dG avatar May 26 '20 13:05 christopher-dG

There is no fine grained permission on GitHub that would let the user close PRs like that. I think the cancel command is a good idea.

nkottary avatar May 27 '20 05:05 nkottary

cool, who's behind the JuliaRegistrator bot / what repo is it?

tlienart avatar May 27 '20 07:05 tlienart

That code is all in Registrator.jl. Nishanth is the most knowledgeable about the comment bot I think.

christopher-dG avatar May 27 '20 20:05 christopher-dG

It seems like this will be a feature that needs to be implemented in Registrator.jl, so I'm transferring the issue here.

DilumAluthge avatar Jun 04 '20 09:06 DilumAluthge