General
General copied to clipboard
New package: BeepBeep v0.1.0
- Registering package: BeepBeep
- Repository: https://github.com/cjungerius/BeepBeep.jl
- Created by: @cjungerius
- Version: v0.1.0
- Commit: 3c55f5ee0c77afd3aacd90323ae1a29196876346
- Reviewed by: @cjungerius
- Reference: https://github.com/cjungerius/BeepBeep.jl/commit/3c55f5ee0c77afd3aacd90323ae1a29196876346#commitcomment-81273484
- Description: Because watched code never finishes!
Your new package
pull request met all of the guidelines for auto-merging and is scheduled to be merged when the mandatory waiting period (3 days) has elapsed.
Since you are registering a new package, please make sure that you have read the package naming guidelines: https://julialang.github.io/Pkg.jl/dev/creating-packages/#Package-naming-guidelines-1
If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock]
in your comment.
pretty much identical to https://github.com/arubhardwaj/Beep.jl
[noblock]
[noblock]
pretty much identical to https://github.com/arubhardwaj/Beep.jl
Does not seem like that one is registered, is it?
pretty much identical to https://github.com/arubhardwaj/Beep.jl
I must confess I somehow missed this one! It doesn't seem to be registered, as @aramirezreyes notes. After browsing through the code I will also say that
- They use a different selection of sounds from what I selected - arguably trivial, I know, but I've grown attached to the
beepR
package, and having a direct analogue for it in Julia was my main motivation in writing this little package. I've tried to closely follow the behaviour of that package where possible. - Perhaps more relevantly, also matching
beepR
, I have included the ability to play arbitrary sounds by path or URL, which I don't see in the other package's code, where additional sounds need to be added by pull request.
I'm not sure what the process here is (I'm partially submitting this to familiarise myself with Julia's package registry) but I believe these differences, and the fact that the other package isn't registered in the first place, mean that this shouldn't be an impediment to merging? I'll leave it to your judgement though.
[noblock]
Yeah, given that the other one is not registered I would encourage @Moelf to add [noblock] to their comment, I don't see a reason this should not be merged.