General icon indicating copy to clipboard operation
General copied to clipboard

New package: DS9ui v1.0.0

Open JuliaRegistrator opened this issue 5 months ago • 11 comments

  • Registering package: DS9ui
  • Repository: https://github.com/astrozot/DS9ui.jl
  • Created by: @astrozot
  • Version: v1.0.0
  • Commit: bcbc75a077cd1baf0b67b48eaf69655e7aab0b8b
  • Reviewed by: @astrozot
  • Reference: https://github.com/astrozot/DS9ui.jl/issues/2
  • Description: SAOImage DS9 User Interface

JuliaRegistrator avatar Jun 20 '25 08:06 JuliaRegistrator

Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of AutoMerge guidelines. If all these guidelines are met, this pull request will be merged automatically, completing your registration. It is strongly recommended to follow the guidelines, since otherwise the pull request needs to be manually reviewed and merged by a human.

1. New package registration

Please make sure that you have read the package naming guidelines.

2. AutoMerge Guidelines are all met! ✅

Your new package registration met all of the guidelines for auto-merging and is scheduled to be merged when the mandatory waiting period (3 days) has elapsed.

3. To pause or stop registration

If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

Tip: You can edit blocking comments to add [noblock] in order to unblock auto-merging.

github-actions[bot] avatar Jun 20 '25 08:06 github-actions[bot]

Could you please add a comparison with https://github.com/JuliaAstro/SAOImageDS9.jl? How these packages differ?

aplavin avatar Jun 20 '25 13:06 aplavin

The package SAOImageDS9.jl implements a relatively low-level interface to SAOImage DS9, and essentially is limited to the set and get XPA commands. My package aims at developing a higher-level interface, including, for example, interactions with DS9 to measure objects' properties or extractions of masks' boundaries. Additionally, I see that SAOImageDS9.jl has not received any significant update in the last 5 years, so I am uncertain if there is any room for a significant further development of that package: an open issue regarding a proposal for further development of the SAOImageDS9 package is "frozen" to January 2021.

astrozot avatar Jun 20 '25 13:06 astrozot

Can you add the functionality comparison to your readme?

Regarding

Additionally, I see that SAOImageDS9.jl has not received any significant update in the last 5 years, so I am uncertain if there is any room for a significant further development of that package: an open issue regarding a proposal for further development of the SAOImageDS9 package is "frozen" to January 2021.

You (or anyone else) can become a maintainer :) It's more convenient for everyone to have a single DS9 interaction package...

aplavin avatar Jun 20 '25 13:06 aplavin

pinging SAOImageDS9 devs: @emmt @abhro @icweaver @sefffal

aplavin avatar Jun 20 '25 13:06 aplavin

You (or anyone else) can become a maintainer :) It's more convenient for everyone to have a single DS9 interaction package...

I see your point, and I will be happy to contribute to the SAOImageDS9 package, provided the timescale for this kind of contribution is reasonable and the maintaner(s) agree.

As a side (vaguely related) point, there are fundamental and widely used packages (StaticArrays, to name one) that have tens of unanswered open issues and tens of open pull requests. Some of these issues (or pull requests) raise (and fix) critical bugs. I know that maintaining a package requires a lot of effort, but I am not sure how to deal with these situations (in the case of StaticArrays I made a fork that fixes a critical bug I found, but does it for me only...).

astrozot avatar Jun 20 '25 14:06 astrozot

Yeah, I would highly recommend merging functionalities into the existing SAOImageDS9.jl package, where we can provide both the low-level and high-level interfaces (as is done with HDF5.jl for example)

abhro avatar Jun 20 '25 14:06 abhro

Thank you for your prompt reply @abhro , I will make a pull request to SAOImageDS9.jl then.

astrozot avatar Jun 20 '25 14:06 astrozot

Happy Friday all! Love to see this, thanks for sharing such a cool package @astrozot. I opened up tracking issues here:

  • https://github.com/JuliaAstro/SAOImageDS9.jl/issues/13
  • https://github.com/astrozot/DS9ui.jl/issues/3

and would be happy to help support merging things on the JuliaAstro side

icweaver avatar Jun 20 '25 18:06 icweaver

You (or anyone else) can become a maintainer :) It's more convenient for everyone to have a single DS9 interaction package...

I see your point, and I will be happy to contribute to the SAOImageDS9 package, provided the timescale for this kind of contribution is reasonable and the maintaner(s) agree.

As a side (vaguely related) point, there are fundamental and widely used packages (StaticArrays, to name one) that have tens of unanswered open issues and tens of open pull requests. Some of these issues (or pull requests) raise (and fix) critical bugs. I know that maintaining a package requires a lot of effort, but I am not sure how to deal with these situations (in the case of StaticArrays I made a fork that fixes a critical bug I found, but does it for me only...).

I agree that having a single package for this kind of thing is preferable for the end users. I would totally agree to upgrade/change/etc. SAOImageDS9. One of my inital objective was to have something to start with and which contributors could improve. But I must say that there were not many such contributors even though some come with many ideas. For examples, see Additional features or DS9 REPL mode.

emmt avatar Jun 21 '25 12:06 emmt

SAOImageDS9.jl has not received any significant update in the last 5 years, so I am uncertain if there is any room for a significant further development of that package: an open issue regarding a proposal for further development of the SAOImageDS9 package is "frozen" to January 2021.

I did not use this package a lot myself (which may explain the timeline of the commits) but recently fixed a few bugs.

emmt avatar Jun 21 '25 12:06 emmt

This pull request has been inactive for 30 days and will be automatically closed 7 days from now. If this pull request should not be closed, please either (1) fix the AutoMerge issues and re-trigger Registrator, which will automatically update the pull request, or (2) post a comment explaining why you would like this pull request to be manually merged. [noblock]

github-actions[bot] avatar Jul 22 '25 12:07 github-actions[bot]

This pull request has been inactive for more than 30 days and has automatically been closed. Feel free to register your package or version again once you fix the AutoMerge issues. [noblock]

github-actions[bot] avatar Jul 29 '25 12:07 github-actions[bot]