New package: CoolPropCycles v0.1.0
- Registering package: CoolPropCycles
- Repository: https://github.com/Sush1090/CoolPropCycles.jl
- Created by: @Sush1090
- Version: v0.1.0
- Commit: 72281436a24a7d5630e696b1181d98ad1e1a4264
- Reviewed by: @Sush1090
- Reference: https://github.com/Sush1090/CoolPropCycles.jl/issues/6#issuecomment-2431617709
- Description: A Julia based simulation framework for thermodynamic cycles using CoolProp and ModelingToolkit
- Release notes:
## Breaking changes
- First set of Components for thermodynamic cycles
Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of AutoMerge guidelines. If all these guidelines are met, this pull request will be merged automatically, completing your registration. It is strongly recommended to follow the guidelines, since otherwise the pull request needs to be manually reviewed and merged by a human.
1. New package registration
Please make sure that you have read the package naming guidelines.
2. AutoMerge Guidelines are all met! ✅
Your new package registration met all of the guidelines for auto-merging and is scheduled to be merged when the mandatory waiting period (3 days) has elapsed.
3. To pause or stop registration
If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.
Tip: You can edit blocking comments to add [noblock] in order to unblock auto-merging.
[noblock] Should this be part of the CoolProp org? @barche @jowr
[noblock] It looks like it uses CoolProp, but it not directly related. We could mention it on the homepage, but it should most likely hasve its own repo and user base.
[noblock] Ok… the two reasons for tagging you was that (a) a CoolProp org/package has some say over packages CoolProp<Anything>, so I wanted you to be aware of this registration; and (b), if there's a possibility for a project to be hosted by an org rather than a personal account, that's always preferable, since it reduces the bus factor.
@jowr Please note that your comment is blocking. Can you edit it to contain [noblock]?
[noblock] OK, I guess you have a point. However, I would prefer to have CoolProp focus on the fluid properties and not the modelling of thermal systems.
Thanks for the heads up with [noblock].
[noblock]
a
CoolProporg/package has some say over packagesCoolProp<Anything>, so I wanted you to be aware of this registration
@goerz @jowr Do I have to change the package name to avoid this?
Do I have to change the package name to avoid this?
No, not unless a CoolProp maintainer had a problem with this package (which they don't seem to have ;-) )
@Sush1090 Your comment is also blocking now. All comments have to contain [noblock]
Well, it's OK to block, since I think the package has to be renamed :)
I haven't had the chance yet to speak to @Sush1090 about this.
Well, it's OK to block, since I think the package has to be renamed :)
I haven't had the chance yet to speak to @Sush1090 about this.
It would probably be nice to have these discussions publicly… especially since I'm a little bit confused by the rename to CarnotCycles in https://github.com/JuliaRegistries/General/pull/118228. I don't think the cycles modeled by this package are actually Carnot, are they?
We can close this
@goerz . Hello - it is based on Carnot type cycles for example Organic Rankine cycle and Vapor Compression Cycles. Hence the name CarnotCycles.jl I don't have other "nice" names. If there are any suggestions please feel free.
edit: It should be able to model the generic Carnot Cycle as well. All the necessary process and components are there. But your point that ORC is not exactly Carnot Cycle is also valid.
edit 2: After thinking about your point - I'll put an example of the generic Carnot Cycle in example. Maybe that should suffice and justify the name?
Alright, sounds good to me!
Closing in favor of https://github.com/JuliaRegistries/General/pull/118228