General icon indicating copy to clipboard operation
General copied to clipboard

New package: FortranNamelists v1.0.0

Open JuliaRegistrator opened this issue 1 year ago • 4 comments

  • Registering package: FortranNamelists
  • Repository: https://gitlab.com/seamsay/FortranNamelists.jl
  • Created by: https://gitlab.com/seamsay
  • Version: v1.0.0
  • Commit: 40fe999635e59c6177759877b89d1137da0135c6
  • Git reference: release

JuliaRegistrator avatar Oct 13 '24 19:10 JuliaRegistrator

Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of AutoMerge guidelines. If all these guidelines are met, this pull request will be merged automatically, completing your registration. It is strongly recommended to follow the guidelines, since otherwise the pull request needs to be manually reviewed and merged by a human.

1. New package registration

Please make sure that you have read the package naming guidelines.

2. AutoMerge Guidelines are all met! ✅

Your new package registration met all of the guidelines for auto-merging and is scheduled to be merged when the mandatory waiting period (3 days) has elapsed.

3. To pause or stop registration

If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

Tip: You can edit blocking comments to add [noblock] in order to unblock auto-merging.

github-actions[bot] avatar Oct 13 '24 19:10 github-actions[bot]

Can you clarify the relationship between this and https://github.com/JuliaRegistries/General/pull/117266? Cf. https://github.com/JuliaRegistries/General/pull/117266#issuecomment-2412399828

goerz avatar Oct 14 '24 21:10 goerz

@goerz Seems we were both unaware that the other was working on something 😅 I'll take a little look at that PR over the weekend and see if I can get a better understanding of what has been done in that package.

Sean1708 avatar Oct 17 '24 10:10 Sean1708

@Sean1708 Thanks for taking a look at our package. If you could parse all the namelist files in https://github.com/anchal-physics/FortranNamelistParser.jl/tree/main/test/data by running a test similar to https://github.com/anchal-physics/FortranNamelistParser.jl/blob/main/test/file_io_tests.jl , then that should cover all our requirements and I will withdraw my PR in favor of yours. Last time I tried it, using the Namelist type, it gave an error: "did not expect character '*' at byte offset 21" which was kind of hard to understand too. Thanks.

anchal-physics avatar Oct 21 '24 06:10 anchal-physics

This pull request has been inactive for 30 days and will be automatically closed 7 days from now. If this pull request should not be closed, please either (1) fix the AutoMerge issues and re-trigger Registrator, which will automatically update the pull request, or (2) post a comment explaining why you would like this pull request to be manually merged. [noblock]

github-actions[bot] avatar Jan 09 '25 12:01 github-actions[bot]

This pull request has been inactive for more than 30 days and has automatically been closed. Feel free to register your package or version again once you fix the AutoMerge issues. [noblock]

github-actions[bot] avatar Jan 16 '25 12:01 github-actions[bot]