CompatHelper.jl icon indicating copy to clipboard operation
CompatHelper.jl copied to clipboard

[FR] The ability to tell CompatHelper "please don't open this PR for another `X` days"

Open DilumAluthge opened this issue 3 years ago • 1 comments

We should have the ability for users to tell CompatHelper "please don't open this PR for another X days", where X ≥ 1. The user should be able to specify the value of X. If X is unspecified, we can default to something like X = 30.

DilumAluthge avatar Jun 02 '21 01:06 DilumAluthge

Thanks for the reply in the other thread. That example seems fair to me, but IMO is the less likely scenario as compared to just that I want to close a CompatHelper PR forever since I'm working on the upgrade myself separately. Viewing the latter case as the more typical one (which is certainly up for debate), then I would say it makes more sense if the default is for CompatHelper to not reopen identical PRs, and instead provide the user a way to manually reopen closed ones, probably by commenting "reopen" or something on the original (closed) PR. Just my 2c based on my experience / workflow.

marius311 avatar Jun 02 '21 02:06 marius311