CompatHelper.jl icon indicating copy to clipboard operation
CompatHelper.jl copied to clipboard

Reduce the number of compat entries in docs and test

Open rikhuijzer opened this issue 3 years ago • 2 comments

This is a feature request. Let some package be called Foo. I think that it would be possible to avoid a compat entry for any package in docs/Project.toml and test/Project.toml for which a compat entry is specified in Project.toml, because both docs and test both depend on Foo anyway. Currently, there is a lot of duplication in these compat entries.

For example, when upgrading to DataFrames 1.0, I received two PRs. One for Project.toml and one for test/Project.toml. When you forget to change one of these compat entries and the entries are strict/narrow, the tests will fail.

rikhuijzer avatar Apr 24 '21 07:04 rikhuijzer

:+1: to this. Would be a very helpful feature.

For example, when upgrading to DataFrames 1.0, I received two PRs. One for Project.toml and one for test/Project.toml. When you forget to change one of these compat entries and the entries are strict/narrow, the tests will fail.

This in particular makes life a bit tricky. Increases the amount of manual intervention in CompatHelper PRs required.

willtebbutt avatar Aug 27 '21 16:08 willtebbutt

This is a feature request. Let some package be called Foo. I think that it would be possible to avoid a compat entry for any package in docs/Project.toml and test/Project.toml for which a compat entry is specified in Project.toml, because both docs and test both depend on Foo anyway. Currently, there is a lot of duplication in these compat entries.

You generally do not need duplicate [deps] entries due to the transitivity you described.

lgoettgens avatar Jun 01 '23 14:06 lgoettgens