pyjulia icon indicating copy to clipboard operation
pyjulia copied to clipboard

Turn on compiled_modules=False automatically?

Open MilesCranmer opened this issue 3 years ago • 2 comments

Could compiled_modules=False be turned on automatically if the user does not have a dynamically linked libpython? As far as I can tell this doesn't present too big of a problem for a user to have the precompilation cache turned off.

https://github.com/JuliaPy/pyjulia/blob/56a739126d3fed0d24e548069ff216fea78fbe1b/src/julia/core.py#L489

This is currently an error, but I think it should instead be a warning to just let the user know that precompilation won't work. I think it should automatically re-run with Julia(..., compiled_modules=False) if compiled_modules=True does not work.

I do this automatically in my library which uses PyJulia: https://github.com/MilesCranmer/PySR/blob/57de9547c4d09ddada4249aa25b541f835fa04b3/pysr/sr.py#L965-L1003, so that users don't have to worry about python versions, but I think it should also be turned on in PyJulia itself.

MilesCranmer avatar Jan 21 '22 16:01 MilesCranmer

That sounds like a good idea. (Although hopefully we can get rid of the libpython restriction once we have https://github.com/JuliaPy/PyCall.jl/pull/945...)

tkf avatar Jan 21 '22 18:01 tkf

bump, we should definitely have this

Moelf avatar Nov 03 '23 14:11 Moelf