PythonCall.jl icon indicating copy to clipboard operation
PythonCall.jl copied to clipboard

Add PySR integration test

Open MilesCranmer opened this issue 1 year ago • 4 comments

Now that PySR has switched to PythonCall.jl, here is the promised integration test :)

I'm installing and running it in a separate virtualenv so as to not interfere with anything.

MilesCranmer avatar Feb 12 '24 06:02 MilesCranmer

This looks cool thanks! However I don't think integration tests are suitable for running on every commit in regular CI. Instead I think it would make sense to have a separate github workflow for integration tests which is run manually - and I'll ensure to run it before each release.

Are you familiar enough with github workflows to do this or would you rather I did it?

cjdoris avatar Feb 18 '24 14:02 cjdoris

Sounds good to me – just adding the workflow_dispatch key right?

Also would it be useful to have a daily/weekly cron job or something, to test against main? (but not so regular as to be a nuisance)

MilesCranmer avatar Feb 18 '24 16:02 MilesCranmer

Yeah a weekly cron job would also be fine.

cjdoris avatar Feb 18 '24 16:02 cjdoris

@cjdoris I have greatly simplified the integration test so I think it is now appropriate to run on each commit. In fact it takes less time than many of the other GitHub actions.

I think it would be very useful to have something like this as it tests more complex workflows for scenarios not probed by the unittests alone, such as giving an early indication of issues such as #537 (due to the PyNULL typo).

What do you think?

MilesCranmer avatar Aug 23 '24 04:08 MilesCranmer