Plots.jl icon indicating copy to clipboard operation
Plots.jl copied to clipboard

Published 20 hours ago • verified publisher icon JuliaPlots

feat: use artifacts instead of PlotlyJS

Open pankgeorg opened this issue 5 months ago • 3 comments

Alternative to #4862, includes #4863

Replaces the download from CDN/scratchspace with an artifact

pankgeorg avatar Feb 02 '24 17:02 pankgeorg

The advantage of this PR over #4862 is that this PR will always have access to the plotly.min.js asset, while #4862 only works when PlotlyJS is loaded by the user, right?

fonsp avatar Feb 08 '24 11:02 fonsp

The advantage of this PR over #4862 is that this PR will always have access to the plotly.min.js asset, while #4862 only works when PlotlyJS is loaded by the user, right?

Yes, exactly. We also directly link to the Plotly release assets, which is also the disadvantage of this PR (the artifact being 110MB)

pankgeorg avatar Feb 09 '24 16:02 pankgeorg

@pankgeorg I created a repository last week to experiment with javascript and bundling that might be relevant for this. The repo is at https://github.com/disberd/PlotlyArtifactsESM and it automatically bundles and release in an artifact ready format the plotly library. If you are still pursuing this you might have a look at it and let me know if it can be used or if you see issues with its implementation.

I am planning on using this in PlutoPlotly for the next release

disberd avatar Mar 20 '24 17:03 disberd