Plots.jl
Plots.jl copied to clipboard
Fixed logic of warning on dimension mismatch
Description
Fixes spurious warnings when missing
/NaN
is at the start or end of input vector, as in
plot([missing; 1:4], color=1:5)
Adds stricter checks with warnings in other cases. Tests pass even when these warnings are changed to errors, but I kept them as warnings to be less breaking.
warn_on_attr_dim_mismatch
really shouldn't have anything to do with segments, so maybe it should be called from elsewhere in the pipeline, but I'm not sure where.
Attribution
- [ ] I am listed in .zenodo.json (see https://github.com/JuliaPlots/Plots.jl/issues/3503)
Codecov Report
Patch coverage: 78.57%
and project coverage change: +0.32%
:tada:
Comparison is base (
349eea4
) 89.96% compared to head (6c32105
) 90.29%. Report is 59 commits behind head on master.
:exclamation: Current head 6c32105 differs from pull request most recent head 77de082. Consider uploading reports for the commit 77de082 to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## master #4735 +/- ##
==========================================
+ Coverage 89.96% 90.29% +0.32%
==========================================
Files 40 40
Lines 8383 8729 +346
==========================================
+ Hits 7542 7882 +340
- Misses 841 847 +6
Files Changed | Coverage Δ | |
---|---|---|
RecipesPipeline/src/utils.jl | 97.26% <ø> (+1.36%) |
:arrow_up: |
src/utils.jl | 92.22% <75.00%> (-0.40%) |
:arrow_down: |
src/recipes.jl | 84.60% <83.33%> (+0.12%) |
:arrow_up: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.