SolidStateDetectors.jl icon indicating copy to clipboard operation
SolidStateDetectors.jl copied to clipboard

Refactor Tests / Increase code coverage in tests

Open lmh91 opened this issue 4 years ago • 3 comments

At the moment, we are simulating quite a number of detectors in our tests. We should reduce that.

I guess besides the comparison to analytic solutions we only need to simulate 2 real detectors. One for cartesian and one for cylindrical coordinates.

We should add then smaller, more specific tests for the geometry, e.g., primitives. But we don't need a full simulation for each primitive.

lmh91 avatar Nov 19 '20 07:11 lmh91

I second this.

I think there still should be a test script that basically runs every single feature and function we have to offer. This should be made available in the package but not as the one that is run automatically. People can run it locally for somewhat larger PRs to ensure nothing really breaks.

schustermartin avatar Nov 19 '20 10:11 schustermartin

This is already in the making! #122 already has script that tests primitives, transformations, sets and read-in. Whenever we merge the new CSG with the already existing simulation code, the current and new test scripts can be combined.

fhagemann avatar Dec 08 '20 17:12 fhagemann

We should create "Test detector" for this covering basically all cases. This should be a dedicated PR tough.

Originally posted by @lmh91 in https://github.com/JuliaPhysics/SolidStateDetectors.jl/pull/206#discussion_r696703345

fhagemann avatar Aug 26 '21 17:08 fhagemann