MPI.jl icon indicating copy to clipboard operation
MPI.jl copied to clipboard

Add `has_rocm` for OpenMPI

Open avik-pal opened this issue 1 year ago • 1 comments

See https://docs.open-mpi.org/en/main/man-openmpi/man3/MPIX_Query_rocm_support.3.html#mpix-query-rocm-support

Seems to be available from v5 of OpenMPI

avik-pal avatar Feb 25 '24 20:02 avik-pal

Can also document has_rocm in https://juliaparallel.org/MPI.jl/stable/knownissues/#Hints-to-ensure-ROCm-aware-MPI-to-be-functional, like has_cuda is documented in the CUDA section.

giordano avatar Mar 11 '24 22:03 giordano

@avik-pal are you interested in moving this forward?

giordano avatar Jun 20 '24 18:06 giordano

Completely fell off my radar, I will finish this over the weekend

avik-pal avatar Jun 20 '24 23:06 avik-pal

Once this is merged, I can implement has_gpu; has_cuda and has_rocm for Cray MPICH

JBlaschke avatar Jun 21 '24 17:06 JBlaschke

Maybe one could add a sentence similar to CUDA (https://github.com/JuliaParallel/MPI.jl/blob/master/docs/src/usage.md)

If using OpenMPI, the status of CUDA support can be checked via the [MPI.has_cuda()](https://github.com/JuliaParallel/MPI.jl/blob/master/docs/src/@ref) function.

in the ROCm-aware section of the docs?

luraess avatar Jun 21 '24 21:06 luraess

Maybe one could add a sentence similar to CUDA (master/docs/src/usage.md)

If using OpenMPI, the status of CUDA support can be checked via the [MPI.has_cuda()](https://github.com/JuliaParallel/MPI.jl/blob/master/docs/src/@ref) function.

in the ROCm-aware section of the docs?

done

avik-pal avatar Jun 22 '24 16:06 avik-pal

Thanks!

giordano avatar Jun 23 '24 13:06 giordano

Can also document has_rocm in https://juliaparallel.org/MPI.jl/stable/knownissues/#Hints-to-ensure-ROCm-aware-MPI-to-be-functional, like has_cuda is documented in the CUDA section.

Last documentation request and the we should be good to go ☝️

giordano avatar Jun 23 '24 13:06 giordano

Updated the docs

avik-pal avatar Jun 23 '24 16:06 avik-pal

Can you erase on master?

vchuravy avatar Jun 23 '24 17:06 vchuravy

Can you erase on master?

What do you want me to erase?

avik-pal avatar Jun 23 '24 19:06 avik-pal

I presume that was meant to be "rebase".

giordano avatar Jun 23 '24 19:06 giordano