Elemental.jl icon indicating copy to clipboard operation
Elemental.jl copied to clipboard

detect Intel MPI in __init__ and print versionString when error occurs

Open AStupidBear opened this issue 4 years ago • 4 comments

AStupidBear avatar May 13 '20 09:05 AStupidBear

It looks like the code changes here don't match the PR title

andreasnoack avatar May 13 '20 09:05 andreasnoack

Is there any problem with this PR?

AStupidBear avatar Jun 09 '20 13:06 AStupidBear

I think you should probably add fixes to support Intel MPI in MPIType and MPIOp as well. Looks to me (from looking at, e.g. oneapi/mpi/2021.1.1/include/mpi.h) that Intel MPI uses the same numerical constant definitions as MPICH exactly, so you could just add :IntelMPI to the if clauses that currently match for MPICH3.

bernstei avatar May 13 '22 15:05 bernstei

Intel MPI should be compatible with MPICH since they are part of the MPICH ABI Compatibility Initiative.

Sideboard avatar May 13 '22 16:05 Sideboard