Yggdrasil icon indicating copy to clipboard operation
Yggdrasil copied to clipboard

[SCS] link against libblastrampoline

Open kalmarek opened this issue 1 year ago • 17 comments

whenever it makes sense; No changes to scsmkl, since it is already linked against mkl directly.

CC: @odow

kalmarek avatar Oct 14 '24 10:10 kalmarek

This needs a new version number (and then some changes to SCS.jl), so let's just wait for the next upstream release.

odow avatar Oct 14 '24 20:10 odow

there's also a build failure due to libblastrampoline not found on aarch64-unknown-freebsd, is that expected @giordano ?

kalmarek avatar Oct 14 '24 23:10 kalmarek

@ararslan what version of libblastrampoline supports aarch64-freebsd? Is it easier to just skip that platform?

giordano avatar Oct 14 '24 23:10 giordano

Should we move freebsd-aarch64 to experimental until Julia 1.12 is out?

ViralBShah avatar Oct 16 '24 14:10 ViralBShah

Should we move freebsd-aarch64 to experimental until Julia 1.12 is out?

The experimental option didn't work very well because it's a moving target, I prefer being explicit.

My general approach with building a package for such a niche platform like aarch64-freebsd is "if it works easily, awesome, if it takes too much effort to make it work then just exclude it and move on".

giordano avatar Oct 16 '24 22:10 giordano

what version of libblastrampoline supports aarch64-freebsd?

I believe it's 5.11.0. I can do a rebuild of 5.4.0 if needed.

ararslan avatar Oct 17 '24 06:10 ararslan

what version of libblastrampoline supports aarch64-freebsd?

I believe it's 5.11.0. I can do a rebuild of 5.4.0 if needed.

should we filter platforms and create two separate deps with different compat for blastrampoline? What is the compat we should use when targeting julia-1.10 and higher?

kalmarek avatar Oct 17 '24 11:10 kalmarek

I believe the only thing to do for now is to filter out freebsd aarch64.

ViralBShah avatar Oct 17 '24 13:10 ViralBShah

IIUC, libblastrampoline is the rare example where bumping the compat is not a problem. I went through a similar situation recently and that was my takeaway. Perhaps @giordano can confirm?

ararslan avatar Oct 17 '24 16:10 ararslan

stdlibs are always bound to a specific version of Julia. I think you did recently on suitesparse, which is a stdlib itself, so the problem doesn't really matter there.

giordano avatar Oct 17 '24 16:10 giordano

Ah right, okay. Looking at the builders that depend on libblastrampoline, the most common compat setting is 5.4, so perhaps it could be worthwhile to rebuild that anyway.

ararslan avatar Oct 17 '24 17:10 ararslan

@ararslan let me know when rebuilt is ready!

kalmarek avatar Oct 17 '24 19:10 kalmarek

Both 1.10.5 and 1.11.0 have libblastrampoline 5.11.0. However 1.10.0 has LBT 5.4.

ViralBShah avatar Oct 18 '24 19:10 ViralBShah

Trying LBT update in in https://github.com/JuliaPackaging/Yggdrasil/pull/9641

ViralBShah avatar Oct 18 '24 19:10 ViralBShah

Thanks Viral! Sorry for not following up on this sooner, I've had basically no time for anything lately.

ararslan avatar Oct 24 '24 16:10 ararslan

@kalmarek @odow Merge?

ViralBShah avatar Oct 25 '24 14:10 ViralBShah

@ViralBShah No, I think we'll wait for a new upstream version

kalmarek avatar Oct 25 '24 23:10 kalmarek

I think this needs to be updated to work on top of #11822

ViralBShah avatar Oct 04 '25 03:10 ViralBShah

Yeah. Ideally we would have merged this in before tagging a release of SCS_jll. We'll need to wait for the next upstream release. This motivated the component_owners mechanism so I can now get a ping before any changes to SCS.

odow avatar Oct 06 '25 22:10 odow

You don't need to wait for an upstream release; the version numbers do not need to agree. (This happens frequently in Yggdrasil.)

eschnett avatar Oct 06 '25 22:10 eschnett

the version numbers do not need to agree. (This happens frequently in Yggdrasil.)

I know, but I try very hard to keep them in sync. I'm not in a rush for LBT in SCS, so it can wait.

odow avatar Oct 06 '25 22:10 odow

SCS 3.2.9 has just been released, so you can add it now without getting the numbers out of sync.

araujoms avatar Oct 12 '25 21:10 araujoms

I'll do it.

odow avatar Oct 12 '25 21:10 odow

See https://github.com/JuliaPackaging/Yggdrasil/pull/12274

odow avatar Oct 12 '25 22:10 odow