Yggdrasil icon indicating copy to clipboard operation
Yggdrasil copied to clipboard

[Doxygen] Update to 1.9.8

Open JamesWrigley opened this issue 2 years ago • 4 comments

In an attempt to fix weird segfaults in another package :octopus:

The previous link was pointing to the auto-generated Github source which apparently can change its hash, so now it points to the tarball built by Doxygen.

JamesWrigley avatar Dec 25 '23 00:12 JamesWrigley

Hmph, looks like Doxygen versions after 1.9.2 use a filesystem library that uses utimensat, which is apparently only available for newer versions of OSX: https://github.com/ziglang/zig/issues/5023

Is there a way to set the minimum OSX version? Or would we need to remove support for OSX entirely?

JamesWrigley avatar Dec 25 '23 00:12 JamesWrigley

https://github.com/JuliaPackaging/Yggdrasil/blob/18413b89feaf52ebfa9afea2ca2c2cfa238e6369/L/libpolars/build_tarballs.jl#L14-L17 https://github.com/JuliaPackaging/Yggdrasil/blob/18413b89feaf52ebfa9afea2ca2c2cfa238e6369/L/libpolars/build_tarballs.jl#L22-L30

giordano avatar Dec 26 '23 20:12 giordano

Thanks, let's see if that works :crossed_fingers: When testing locally I got IO errors for some reason when running rm -rf /opt/${target}/${target}/sys-root/System, but I assume that's something fishy with my system. Also hopefully fixed the windows build errors with the new patch, I'll look into getting that upstreamed (see: https://github.com/doxygen/doxygen/pull/9854).

JamesWrigley avatar Dec 26 '23 22:12 JamesWrigley

Ok, builds all pass but I see this warning:

┌ Warning: Minimum instruction set detected for bin/doxygen.exe is avx2, not x86_64 as desired.
│   platform = "x86_64-w64-mingw32-cxx11"
└ @ BinaryBuilder.Auditor ~/.julia/dev/BinaryBuilder/src/Auditor.jl:323

Which I assume means that this will crash on windows machines without avx2? On the other hand, the 1.9.2 build also had that warning so at least this version isn't making things worse... If we're ok with the warning, then I think this can be merged.

JamesWrigley avatar Dec 26 '23 23:12 JamesWrigley

We have Doxygen 1.10.0 as of https://github.com/JuliaPackaging/Yggdrasil/pull/8294, so closing this one.

imciner2 avatar Apr 02 '24 20:04 imciner2