Yggdrasil icon indicating copy to clipboard operation
Yggdrasil copied to clipboard

WIP: [Torch] Renamed Torch to TorchCUDA, and added a CPU-only Torch

Open stemann opened this issue 3 years ago • 4 comments

Currently a WIP. Aims at resolving https://github.com/FluxML/Torch.jl/issues/20.

Similar approach as for ONNXRuntime - separate binaries for CPU-only and CUDA etc. (CPU: #4369, CUDA: #4386).

Relates to: #1529

stemann avatar Feb 21 '22 15:02 stemann

Does this need to be a different package? Or can we turn this into a variant?

vchuravy avatar Feb 22 '22 15:02 vchuravy

Does this need to be a different package? Or can we turn this into a variant?

If eventually both CPU, CUDA and ROCm builds are available, wouldn't the different sets of dependencies necessitate different packages?

stemann avatar Feb 22 '22 16:02 stemann

You still have the same issue that if Torch.jl includes Torch_jll, TorchCUDA_jll,... all dependencies must be fulfilled. Better to use a platform tag and platform specific dependencies.

vchuravy avatar Feb 22 '22 17:02 vchuravy

You still have the same issue that if Torch.jl includes Torch_jll, TorchCUDA_jll,... all dependencies must be fulfilled. Better to use a platform tag and platform specific dependencies.

Right, I see. Is there some discussion/registry of defined/reserved platform tags? I.e. that "cuda" is reserved for CUDA and so on for e.g. "amd_rocm", "intel_oneapi", "apple_coreml", ...

stemann avatar Mar 05 '22 10:03 stemann

Superseded by #4554

stemann avatar Sep 04 '22 15:09 stemann