Scratch.jl icon indicating copy to clipboard operation
Scratch.jl copied to clipboard

README typo: global ref[] = ...

Open fonsp opened this issue 2 years ago • 2 comments

Hey! Scratch is cool!

Little typo fix in the README: a ref change does not need the global keyword

fonsp avatar Dec 02 '23 13:12 fonsp

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (d68e430) 87.73% compared to head (a1bda7b) 87.73%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #49   +/-   ##
=======================================
  Coverage   87.73%   87.73%           
=======================================
  Files           1        1           
  Lines         106      106           
=======================================
  Hits           93       93           
  Misses         13       13           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Dec 02 '23 13:12 codecov[bot]

Quite a bit have changed since this was written. In particular there is now Base.pkgversion, so I think all of this can be replaced by e.g.

version_specific_scratch = let pkg_version = pkgversion(@__MODULE__)
    scratch_name = "data_for_version-$(pkg_version.major).$(pkg_version.minor)"
    @get_scratch!(scratch_name)
end

fredrikekre avatar Dec 03 '23 02:12 fredrikekre