BinaryBuilder.jl icon indicating copy to clipboard operation
BinaryBuilder.jl copied to clipboard

build all code with -fasynchronous-unwind-tables

Open vtjnash opened this issue 6 years ago • 5 comments

This is required to support high-quality profile results without impacting code quality (as the even more reliable alternative -mno-omit-frame-pointer might do)

vtjnash avatar Aug 16 '19 21:08 vtjnash

Do you suggest having our compiler wrappers automatically force -fasynchronous-unwind-tables? Which compilers and platforms would this apply to?

staticfloat avatar Dec 06 '19 01:12 staticfloat

It’s default on x86. Otherwise, can’t help you. Usually not needed on platforms with a frame pointer though (everything but x86)

vtjnash avatar Dec 06 '19 02:12 vtjnash

If it's default on x86, is there any action item here?

staticfloat avatar Dec 06 '19 05:12 staticfloat

Looks like this indirectly may have been he cause of https://github.com/JuliaLang/julia/issues/38547 CI problems, due to missing unwind-tables (which I'll also work-around in Julia, since we can't assume all libraries have the information).

I think I mistyped that above, and meant specifically amd64. The i686 might not have this option by default.

vtjnash avatar Nov 29 '20 17:11 vtjnash

I don't think I actually changed the compiler wrappers to include this.

staticfloat avatar Nov 30 '20 17:11 staticfloat