BinDeps.jl icon indicating copy to clipboard operation
BinDeps.jl copied to clipboard

Published 20 hours ago • verified publisher icon JuliaPackaging

BinDeps keyword argument validation

Open staticfloat opened this issue 8 years ago • 6 comments

Tested on OSX.

staticfloat avatar May 13 '16 17:05 staticfloat

Thanks for this! Though looks like you need to support os (or at least accept it with a deprecation warning).

nalimilan avatar May 14 '16 22:05 nalimilan

Yep, missed a bunch because I was only looking for get(opts, :arg) instead of haskey(opts, :arg).

staticfloat avatar May 16 '16 17:05 staticfloat

Bump. I forget, was this ready to go?

tkelman avatar Jun 21 '16 11:06 tkelman

We should run the tests again just in case.

staticfloat avatar Jun 21 '16 14:06 staticfloat

There, I just rebased onto master. Let's make sure everything is still green.

staticfloat avatar Jun 21 '16 14:06 staticfloat

Apparently HttpParser hasn't been fixed since we removed the 0.4 deprecations on nightly. HttpParser has some API changes not yet resolved that mean it currently can't be tagged until an upgrade path is put in place for existing installs... and windows binaries are rebuilt for the new version. Will need a more precise validation callback etc but this is an issue for a different repo...

tkelman avatar Jun 21 '16 14:06 tkelman