NIfTI.jl icon indicating copy to clipboard operation
NIfTI.jl copied to clipboard

Why are method2 and method3 mutually exclusive?

Open vsaase opened this issue 6 years ago • 1 comments

https://github.com/JuliaIO/NIfTI.jl/blob/a9e50b9f6ddf5e8b7c09fffdfe9a3d48a962c0fe/src/NIfTI.jl#L344

Hi, the nifti standard (https://nifti.nimh.nih.gov/nifti-1/documentation/nifti1fields/nifti1fields_pages/qsform.html) does'nt say that.

also here https://github.com/JuliaIO/NIfTI.jl/blob/a9e50b9f6ddf5e8b7c09fffdfe9a3d48a962c0fe/src/NIfTI.jl#L366 why do you write method2 || method3, this leads to a problem with e.g. ITK-SNAP which then thinks it can use method2, even if only method3 is availabe

vsaase avatar Sep 06 '19 07:09 vsaase

You're correct. However, last I checked ITK only uses the sform. They may have changed this though. Either way we need to fix this.

Tokazama avatar Sep 06 '19 08:09 Tokazama