`limits_box` function in `fminbox.jl` is unused. Can it be removed?

Open nhz2 opened this issue 3 years ago • 1 comments

From what I can tell https://github.com/JuliaNLSolvers/Optim.jl/blob/89b6804badaf49e4df1a54da0b9378507f7aa583/src/multivariate/solvers/constrained/fminbox.jl#L152 isn't being used anywhere. Can this function be deleted?

Mar 07 '22 18:03 nhz2

I have to look back at the history to figure out why it isn't used. I think it's a mistake. I think it used to be used to set alphamax for fminbox+cgdescent (now HagerZhang), but it seems to have been lost somewhere along the way.

Mar 07 '22 20:03 pkofod