Optim.jl icon indicating copy to clipboard operation
Optim.jl copied to clipboard

Published 20 hours ago • verified publisher icon JuliaNLSolvers

Equality test instead of assignment in `IPNewton`?

Open ForceBru opened this issue 2 years ago • 1 comments

state.ev == equality_violation(constraints, state) in this snippet of update_state! is an equality test, but it looks like assignment was meant:

https://github.com/JuliaNLSolvers/Optim.jl/blob/adc5b277b3f915c25233b45f8f2dd61006815e63/src/multivariate/solvers/constrained/ipnewton/ipnewton.jl#L282-L288

Looks like currently the algorithm only updates state.ev here:

https://github.com/JuliaNLSolvers/Optim.jl/blob/adc5b277b3f915c25233b45f8f2dd61006815e63/src/multivariate/solvers/constrained/ipnewton/ipnewton.jl#L176-L179

ForceBru avatar Feb 04 '22 13:02 ForceBru

Thanks, feel like making a PR? I promise to review quickly :)

pkofod avatar Feb 08 '22 08:02 pkofod