Compute JVP in line searches
Based on https://github.com/JuliaNLSolvers/NLSolversBase.jl/pull/168 and https://github.com/JuliaNLSolvers/LineSearches.jl/pull/187.
~~The diff would be cleaner if #1195 (which depends on #1209) would be available on the master branch.~~
Based on #1212.
Currently, tests are failing due to missing definitions of NLSolversBase.value_jvp! etc. for ManifoldObjective.
this one also has conflicts for the same reason as the AD pr I suppseo
I see you're hitting all the wrappers
Codecov Report
:x: Patch coverage is 86.25954% with 18 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 85.94%. Comparing base (540c97b) to head (536eaa9).
Additional details and impacted files
@@ Coverage Diff @@
## master #1210 +/- ##
==========================================
- Coverage 86.83% 85.94% -0.89%
==========================================
Files 44 43 -1
Lines 3540 3487 -53
==========================================
- Hits 3074 2997 -77
- Misses 466 490 +24
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Locally (macOS aarch64) and on MacOS (aarch64) in CI all tests pass, but on ubuntu and windows 4 tests fail...