Optim.jl icon indicating copy to clipboard operation
Optim.jl copied to clipboard

Compute JVP in line searches

Open devmotion opened this issue 1 month ago • 4 comments

Based on https://github.com/JuliaNLSolvers/NLSolversBase.jl/pull/168 and https://github.com/JuliaNLSolvers/LineSearches.jl/pull/187.

~~The diff would be cleaner if #1195 (which depends on #1209) would be available on the master branch.~~

Based on #1212.


Currently, tests are failing due to missing definitions of NLSolversBase.value_jvp! etc. for ManifoldObjective.

devmotion avatar Nov 24 '25 13:11 devmotion

this one also has conflicts for the same reason as the AD pr I suppseo

pkofod avatar Nov 24 '25 14:11 pkofod

I see you're hitting all the wrappers

pkofod avatar Nov 25 '25 07:11 pkofod

Codecov Report

:x: Patch coverage is 86.25954% with 18 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 85.94%. Comparing base (540c97b) to head (536eaa9).

Files with missing lines Patch % Lines
src/multivariate/solvers/constrained/fminbox.jl 73.33% 8 Missing :warning:
src/api.jl 50.00% 3 Missing :warning:
src/multivariate/solvers/constrained/samin.jl 60.00% 2 Missing :warning:
src/Manifolds.jl 92.30% 1 Missing :warning:
src/multivariate/solvers/first_order/adam.jl 50.00% 1 Missing :warning:
src/multivariate/solvers/first_order/adamax.jl 50.00% 1 Missing :warning:
...ariate/solvers/second_order/newton_trust_region.jl 50.00% 1 Missing :warning:
src/types.jl 75.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1210      +/-   ##
==========================================
- Coverage   86.83%   85.94%   -0.89%     
==========================================
  Files          44       43       -1     
  Lines        3540     3487      -53     
==========================================
- Hits         3074     2997      -77     
- Misses        466      490      +24     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Dec 01 '25 20:12 codecov[bot]

Locally (macOS aarch64) and on MacOS (aarch64) in CI all tests pass, but on ubuntu and windows 4 tests fail...

devmotion avatar Dec 01 '25 21:12 devmotion