NLSolvers.jl icon indicating copy to clipboard operation
NLSolvers.jl copied to clipboard

do not allocate in `x_converged`

Open longemen3000 opened this issue 1 year ago • 6 comments

it changes y = x .- z for an iterator. ideally, a custom struct could be provided for this, i imagine some problems could arise if using CUArrays?

longemen3000 avatar May 03 '23 08:05 longemen3000

I suppose preallocating y is an alternative ?

pkofod avatar May 03 '23 10:05 pkofod

it is an alternative. Ideally, there should be a way to calculate norm(dx) without allocating somewhere, but the last time i asked, that was the agreed-upon solution

longemen3000 avatar May 03 '23 20:05 longemen3000

tests failed it seems

pkofod avatar Jun 12 '23 19:06 pkofod

ah that was the anderson test

pkofod avatar Jun 12 '23 19:06 pkofod

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@8d4792b). Click here to learn what that means. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #54   +/-   ##
=========================================
  Coverage          ?   76.47%           
=========================================
  Files             ?       54           
  Lines             ?     2776           
  Branches          ?        0           
=========================================
  Hits              ?     2123           
  Misses            ?      653           
  Partials          ?        0           

codecov[bot] avatar Jun 12 '23 19:06 codecov[bot]

Looks like CI passed

ararslan avatar Jun 21 '23 23:06 ararslan