LsqFit.jl icon indicating copy to clipboard operation
LsqFit.jl copied to clipboard

Add a precompilation workload

Open JamesWrigley opened this issue 11 months ago • 4 comments

On my system this reduces the time taken for a subset of the curve fitting tests from ~12.5s to ~2.5s.

Note that support for BigFloat's is currently broken with NLSolversBase 7.9 so CI won't pass (hacky fix here https://github.com/JuliaNLSolvers/NLSolversBase.jl/pull/160, but @gdalle kindly agreed to look into it further).

JamesWrigley avatar Apr 06 '25 11:04 JamesWrigley

If big float support broke because of the NLSolversBase release we should bound the version that is supported by v.0.15.x of LsqFit.jl

pkofod avatar Apr 07 '25 19:04 pkofod

It would indeed be interesting to know whether it worked prior to the recent changes. I saw that @lcontento had encountered the seemingly same issue (I opened a PR with a fix to ForwardDiff) in NLsolve 5 years ago: https://github.com/JuliaDiff/ForwardDiff.jl/issues/436

devmotion avatar Apr 07 '25 21:04 devmotion

Yeah it worked because NLSolversBase used y = copy(...) instead of y = similar(...) before the DI integration came along. But I think the right fix is the one in ForwardDiff https://github.com/JuliaDiff/ForwardDiff.jl/pull/743

gdalle avatar Apr 07 '25 21:04 gdalle

Okay, forgetting the ForwardDiff errors we can include this, but we need to bump Julia to v1.9

pkofod avatar Aug 24 '25 07:08 pkofod