LsqFit.jl icon indicating copy to clipboard operation
LsqFit.jl copied to clipboard

Accept or reject matrix input

Open mcabbott opened this issue 5 years ago • 0 comments

As discussed here: https://discourse.julialang.org/t/error-in-mul-c-a-b-if-size-b-n-1/47999

At present curve_fit(model, xdata::AbstractArray, ydata::AbstractArray, p0::AbstractArray; ...) looks like it accepts arrays, and claims to accept arrays in its docstring, but in fact seems to only accept vectors.

It would be less confusing if the signature was ::AbstractVector, but even better, it looks like adding a few vec calls might easily allow ::AbstractArray to just work.

mcabbott avatar Oct 12 '20 18:10 mcabbott