MusicProcessing.jl icon indicating copy to clipboard operation
MusicProcessing.jl copied to clipboard

Bugfixes, updates to remove warnings, & unit test improvements

Open gnadt opened this issue 1 year ago • 8 comments

gnadt avatar Apr 14 '24 22:04 gnadt

tests still fail, any chance to make them work in this PR? we could tag a release if that's the case...

Datseris avatar Apr 15 '24 08:04 Datseris

Looking into it, seems to be an issue with alsa_plugins_jll

gnadt avatar Apr 16 '24 07:04 gnadt

even if you can't make the tests pass this is still fantastic progress!!!

But to release a new version we probably would need passing tests.

Datseris avatar Apr 16 '24 08:04 Datseris

Yeah no worries, I'm trying to figure out the alsa_plugins_jll issue, but I'm not familiar with Binary Builder, so it's slow

gnadt avatar Apr 16 '24 19:04 gnadt

Ok I figured that wouldn't work, may need to wait for a PortAudio fix: https://github.com/JuliaAudio/PortAudio.jl/pull/125

Alternatively, I can revert to @eval import PortAudio, but that's just avoiding issue instead of resolving

gnadt avatar Apr 16 '24 21:04 gnadt

I'll ask PortAudio devs to merge your PR. (In the meantime, please update that PR's description and bump project.toml version?)

Datseris avatar Apr 17 '24 08:04 Datseris

I don't think I should be the one deciding on a version bump for a package I'm not familiar with?

gnadt avatar Apr 17 '24 14:04 gnadt

@Datseris should be all set. I had to revert to using @eval import PortAudio like before because I don't think the issues in other packages causing it to fail on ubuntu-latest will be fixed anytime soon (or ever). Fixed a bunch of bugs so at least the readme examples all work now (in addition to the tests).

gnadt avatar Apr 20 '24 19:04 gnadt

@Datseris does this need anything else or are you just busy?

gnadt avatar Apr 28 '24 21:04 gnadt

Sorry, I was just busy, thanks for fixing this. I'll tag a new release now!

Datseris avatar Apr 29 '24 09:04 Datseris

Thank you!

gnadt avatar Apr 29 '24 14:04 gnadt

Well, thank YOU For fixing this !

Datseris avatar Apr 29 '24 19:04 Datseris

No problem, just wish I had seen #10 earlier! Also fyi, there are 2 CompatHelper PRs that can be closed, and maybe re-enable the CompatHelper workflow?

gnadt avatar Apr 29 '24 20:04 gnadt

I closed the PRs and registerer 2.0 in the general registry. Do you mind doing a PR that updates all the github workflows?

Datseris avatar Apr 29 '24 21:04 Datseris

Yep, no problem

gnadt avatar Apr 29 '24 22:04 gnadt