EmbraceUncertainty icon indicating copy to clipboard operation
EmbraceUncertainty copied to clipboard

tweaks to figures, moved tidierplots figures to AoG

Open ajinkya-k opened this issue 9 months ago • 10 comments

longitudinal.qmd

  • all figures now in pure julia
  • cleaned up some legends
  • fixed a typo (Itercept) -> (Intercept)

largescaleobserved

  • moved all figures to AlgebraOfGraphics
  • added extra panel to L22 vs full memory size plot
  • this allows removing TidierPlots as a dependency, which will allow us to set alpha for histograms in intro.qmd (see below)
  • this allows us to remove RCall as a dependency (which should get rid of Conda)

intro.qmd:

  • added alpha to histograms

ajinkya-k avatar Mar 26 '25 19:03 ajinkya-k

preview here: https://ajinkya-k.github.io/EmbraceUncertainty/longitudinal.html#the-elstongrizzle-data

ajinkya-k avatar Mar 26 '25 19:03 ajinkya-k

There is just one more plot left to move from R to Julia

ajinkya-k avatar Mar 27 '25 21:03 ajinkya-k

@palday can we get this merged?

ajinkya-k avatar May 07 '25 04:05 ajinkya-k

this will get rid of most if not all R dependency

ajinkya-k avatar May 07 '25 04:05 ajinkya-k

a little bit of history here: we were actually working on moving in the other direction, i.e. porting all the AoG plots to Tidier. There were two reasons for this:

  • AoG had become unmaintained (no longer an issue since Julius reinvigorated the project)
  • @dmbates thought that the Tidier ecosystem might be more accessible to new/potential converts from R

I don't have a terribly strong preference either way, but I don't want us to be bouncing back and forth as TiderPlots and AoG one-up each other.

I think porting R-based figures to Julia is an obvious improvement -- could you split that out into a separate PR that I'll review and then we can leave the bigger Tidier vs AoG discussion for this PR?

Also, I haven't checked the render yet, but make sure the lattice plot in Julia matches the aspect ratio in R. @dmbates has noted that the human eye is very good at pickup deviations from a 45 degree diagonal and so it's good to have an aspect ratio that makes that diagonal meaningful. (I'm doing a horrible job explaining this.)

palday avatar May 08 '25 03:05 palday

@palday see #92 which only has R -> julia plot conversions

ajinkya-k avatar May 08 '25 03:05 ajinkya-k

@palday I dont understand the BADCERT_EXPIRED error i get when trying to preview my PR on my fork. See here. This error does not occur on my local

Any idea what this is?

ajinkya-k avatar May 14 '25 04:05 ajinkya-k

Your local copy has that data cached, so it doesn't have to re-download it, but the CI runner needs to pull it down. It looks like the certificate expired at Tue, 13 May 2025 19:02:04 GMT, so that's why it just now started failing.

palday avatar May 14 '25 04:05 palday

Your local copy has that data cached, so it doesn't have to re-download it, but the CI runner needs to pull it down. It looks like the certificate expired at Tue, 13 May 2025 19:02:04 GMT, so that's why it just now started failing.

I see. any idea how i can fix it?

ajinkya-k avatar May 14 '25 04:05 ajinkya-k

Just have to wait for the site owner to fix their certificate. Hopefully they notice soon...

palday avatar May 14 '25 04:05 palday